[Lldb-commits] [PATCH] D38552: LLDB cmake fix: define LLDB_CONFIGURATION_xxx based on the build type

[Leonard Mosescu via Phabricator via lldb-commits]

lemo added a comment.

Good point, I wouldn't be surprised if that was the case at some point, but right now the main llvm CMakeLists.txt has this:

...
if (NOT CMAKE_BUILD_TYPE AND NOT CMAKE_CONFIGURATION_TYPES)

  message(STATUS "No build type selected, default to Debug")
  set(CMAKE_BUILD_TYPE "Debug" CACHE STRING "Build type (default Debug)" FORCE)

endif()
...

I will double check though, thanks for pointing this out.


https://reviews.llvm.org/D38552