[Lldb-commits] [PATCH] D38153: Inhibit global lookups for symbols in the IR dynamic checks

Sean Callanan via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Sep 25 05:04:20 PDT 2017


spyffe updated this revision to Diff 116444.
spyffe added a comment.

Applied Greg's and Zachary's suggestions:

- Used `R"(...)"` for multiline strings.
- Used `StringRef`s appropriately.
- Factored out symbol-ignoring into a function shared between `ClangASTSource` and `ClangExpressionDeclMap`.


Repository:
  rL LLVM

https://reviews.llvm.org/D38153

Files:
  source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
  source/Plugins/ExpressionParser/Clang/ClangASTSource.h
  source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp
  source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38153.116444.patch
Type: text/x-patch
Size: 12550 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170925/63272e0c/attachment-0001.bin>


More information about the lldb-commits mailing list