[Lldb-commits] [PATCH] D37923: Implement interactive command interruption

[Adrian McCarthy via Phabricator via lldb-commits]

amccarth accepted this revision.
amccarth added a comment.

LGTM.

But just a thought:  Is it worth doing all the work to scan for line endings for the interruption points?  What if, instead, it just printed the next _n_ characters on each iteration until the entire buffer has been printed.  Sure, sometimes an interruption will split a line, and sometimes it won't.  I'm not sure that's important for interactive usage.  It would mean less fiddly code, faster output (because you don't have to scan every character), and a zillion short lines will print as fast as a smaller number of longer lines that represents the same volume of text.


https://reviews.llvm.org/D37923