[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Sep 13 10:44:52 PDT 2017


jingham accepted this revision.
jingham added a comment.

This looks okay for now.  It will end up sending a Running & then a Stopped event.  That's a little awkward, but that happens in the ordinary course of debugging anyway so it shouldn't freak anybody out.

It would be better to find a place where this can be fixed before we send the running event, but that's going to take more thinking, and I don't see that desire should block this patch.  But can you file another PR to go figure out how to fix this closer to the source, so we don't forget to fix this next time we're in the bowels of the process event code?

Thanks!


https://reviews.llvm.org/D37651





More information about the lldb-commits mailing list