[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)
Jim Ingham via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 8 16:43:28 PDT 2017
jingham requested changes to this revision.
jingham added a comment.
This seems like an awkward solution to me. Having CanResume and DoResume seems like it over-determines the problem.
Why wasn't it enough for DoResume to fail and the error to be propagated?
I'm also uncomfortable that this is making a possible code path for some programmer error to cause a fatal error in lldb (which we really want never to happen). It would be much better to rely on the failure of DoResume.
More information about the lldb-commits