[Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)
Stephane Sezer via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Sep 8 16:35:47 PDT 2017
sas requested changes to this revision.
sas added a comment.
This revision now requires changes to proceed.
I think it would be cleaner/smaller if you didn't use pure-virtual functions, but instead you had `CanReseume()` return `false` in `Process.h`, and had a default implementation of `DoResume()` that called `llvm::report_fatal_error()`.
Instead, here, you're defaulting `CanResume()` to `true` and forcing every child class to redefine as `false` and provide an error'ing implementation of `DoResume()`.
More information about the lldb-commits