[Lldb-commits] [PATCH] D36804: Add initial support to PowerPC64 little endian (POWER8)

[Hal Finkel via Phabricator via lldb-commits]

hfinkel accepted this revision.
hfinkel added inline comments.
This revision is now accepted and ready to land.


================
Comment at: source/Core/ArchSpec.cpp:375
      SUBTYPE_MASK},
+    {ArchSpec::eCore_ppc64le_generic, llvm::MachO::CPU_TYPE_POWERPC64, CPU_ANY,
+     UINT32_MAX, SUBTYPE_MASK},
----------------
gut wrote:
> hfinkel wrote:
> > I doubt this is needed. There's no Darwin support to speak of.
> Oh, I see. The MachO object type is only used by MacOS, right? Then I can remove, you are right.
I'm pretty sure that's correct.

Otherwise, this LGTM.



https://reviews.llvm.org/D36804