[Lldb-commits] [PATCH] D36885: [cmake] Explicitly link dependency libraries in the Host library

[Michał Górny via Phabricator via lldb-commits]

mgorny added inline comments.


================
Comment at: source/Host/CMakeLists.txt:166-168
+  if (LIBXML2_FOUND)
+    list(APPEND EXTRA_LIBS ${LIBXML2_LIBRARIES})
+  endif()
----------------
zturner wrote:
> Even if libxml is found, that doesn't mean the build is configured to use it, does it?  Correct me if I'm wrong.  if "libxml exists" is the same as "i want to use libxml" then this seems fine.
Strictly speaking, it's not the same. However, LLDB build system does not provide an explicit option to disable building with libxml2 support, so it's not a regression. It's exactly the same logic as used in other parts of LLDB. If you want, I can look into adding an additional conditional for it in a followup patch. However, I'm not sure if it should be applied to APPLE as well or not since the presumption of libxml2 is unconditional there right now.


Repository:
  rL LLVM

https://reviews.llvm.org/D36885