[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address

[Nitesh Jain via Phabricator via lldb-commits]

nitesh.jain updated this revision to Diff 110698.
nitesh.jain retitled this revision from "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address" to "[LLDB][MIPS] The symbol with NOTYPE and having section type dwarf doesn't contain any valid address".
Herald added a subscriber: emaste.

https://reviews.llvm.org/D35784

Files:
  source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp


Index: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
===================================================================
--- source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
+++ source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
@@ -2154,6 +2154,12 @@
       break;
     default:
       symbol_section_sp = section_list->GetSectionAtIndex(section_idx);
+      // If symbol type is Invalid then check for symbol section type
+      if (symbol.getType() == STT_NOTYPE && symbol_section_sp &&
+          symbol_section_sp->GetType() > eSectionTypeDataObjCCFStrings &&
+          symbol_section_sp->GetType() < eSectionTypeELFSymbolTable)
+          symbol_section_sp = nullptr;
+
       break;
     }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35784.110698.patch
Type: text/x-patch
Size: 698 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170811/868ebcf1/attachment.bin>