[Lldb-commits] [PATCH] D35784: [LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address

Nitesh Jain via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Aug 9 05:44:51 PDT 2017


nitesh.jain updated this revision to Diff 110364.
nitesh.jain retitled this revision from "[LLD][MIPS] Fix Address::GetAddressClass() to return correct AddressClass based on the load address" to "[LLDB][MIPS] The symbol with NOTYPE doesn't contain any valid address".

https://reviews.llvm.org/D35784

Files:
  source/Symbol/Symbol.cpp


Index: source/Symbol/Symbol.cpp
===================================================================
--- source/Symbol/Symbol.cpp
+++ source/Symbol/Symbol.cpp
@@ -113,6 +113,8 @@
 }
 
 bool Symbol::ValueIsAddress() const {
+  if (m_type == eSymbolTypeInvalid)
+    return false;
   return m_addr_range.GetBaseAddress().GetSection().get() != nullptr;
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35784.110364.patch
Type: text/x-patch
Size: 354 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170809/a9d90add/attachment.bin>


More information about the lldb-commits mailing list