[Lldb-commits] [PATCH] D36358: [lldb] [cmake] Add explicit linkage from Core to curses

[Michał Górny via Phabricator via lldb-commits]

mgorny created this revision.

The Core library calls functions provided by the curses library. Add
an appropriate explicit LINK_LIBS to ${CURSES_LIBRARIES} to propagate
the dependency correctly within the build system.

It seems that so far the linkage was handled by some kind of implicit
magic LLDB_SYSTEM_LIBS variable. However, it stopped working for
unittests for some reason, and I don't see a point in wasting my time
trying to figure out why this hack stopped working if the same result
can be achieved by exposing the correct dependency in the Core library,
and letting CMake propagate it.


Repository:
  rL LLVM

https://reviews.llvm.org/D36358

Files:
  source/Core/CMakeLists.txt


Index: source/Core/CMakeLists.txt
===================================================================
--- source/Core/CMakeLists.txt
+++ source/Core/CMakeLists.txt
@@ -67,6 +67,9 @@
     BinaryFormat
     Support
     Demangle
+
+  LINK_LIBS
+    ${CURSES_LIBRARIES}
   )
 
 # Needed to properly resolve references in a debug build.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D36358.109876.patch
Type: text/x-patch
Size: 333 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170805/b5bd395b/attachment.bin>