[Lldb-commits] [PATCH] D33213: Use socketpair on all Unix platforms

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jul 24 09:58:22 PDT 2017


clayborg requested changes to this revision.
clayborg added a comment.
This revision now requires changes to proceed.

Please init fd



================
Comment at: tools/lldb-server/lldb-gdbserver.cpp:388
   bool reverse_connect = false;
+  int connection_fd;
 
----------------
This must be initialized to -1 since only the 'F' case will store to this. Pretty much all of the time random memory would be used for this and incorrectly try to use a random integer as a file descriptor.


https://reviews.llvm.org/D33213





More information about the lldb-commits mailing list