[Lldb-commits] [PATCH] D35113: Clean up lldb-types.h

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jul 7 02:35:52 PDT 2017


labath created this revision.
Herald added a subscriber: ki.stfu.

It defined a couple of types (condition_t) which we don't use anymore,
as we have c++11 goodies now. I remove these definitions.

Also it unnecessarily included a couple of headers which weren't
necessary for it's operation. I remove these, and place the includes in
the relevant files (usually .cpp, usually in Host code) which use them.
This allows us to reduce namespace pollution in most of the lldb files
which don't need the OS-specific definitions.


https://reviews.llvm.org/D35113

Files:
  include/lldb/Host/MainLoop.h
  include/lldb/Host/PosixApi.h
  include/lldb/lldb-types.h
  source/Host/common/File.cpp
  source/Host/common/Socket.cpp
  source/Host/common/TCPSocket.cpp
  source/Host/linux/Host.cpp
  source/Host/linux/HostInfoLinux.cpp
  source/Host/posix/ConnectionFileDescriptorPosix.cpp
  source/Host/posix/FileSystem.cpp
  source/Host/posix/HostProcessPosix.cpp
  source/Host/posix/LockFilePosix.cpp
  source/Host/posix/ProcessLauncherPosixFork.cpp
  source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp
  source/Plugins/Platform/gdb-server/PlatformRemoteGDBServer.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/Linux/NativeThreadLinux.h
  source/Plugins/Process/Linux/ProcessorTrace.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  source/Target/Target.cpp
  tools/driver/Driver.cpp
  tools/lldb-mi/MICmnLLDBDebugger.cpp
  tools/lldb-mi/MIDriver.cpp
  tools/lldb-mi/MIDriverMain.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35113.105603.patch
Type: text/x-patch
Size: 12723 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170707/18140198/attachment-0001.bin>


More information about the lldb-commits mailing list