[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 6 15:10:21 PDT 2017


krytarowski added inline comments.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115
   _type:                                                                       \
   name = #_type
   switch (type) {
----------------
brunoalr wrote:
> joerg wrote:
> > labath wrote:
> > > If we go about renaming them, then we should change this, as we still want to display the standard name of the entries.
> > Or name = "AUXV_AT_???" ENTRY_NAME(type) name = #type and then return name + 4;
> Hmm that looks too "hacky", doesn't it?
`name + 4` looks prettier to me.


https://reviews.llvm.org/D35065





More information about the lldb-commits mailing list