[Lldb-commits] [lldb] r307320 - Change remaining references to lit.util.capture to use subprocess.check_output.

David L. Jones via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 6 14:46:48 PDT 2017


Author: dlj
Date: Thu Jul  6 14:46:47 2017
New Revision: 307320

URL: http://llvm.org/viewvc/llvm-project?rev=307320&view=rev
Log:
Change remaining references to lit.util.capture to use subprocess.check_output.

Summary:
The capture() function was removed in r306625. This should fix PGO breakages
reported by Michael Zolotukhin.

Reviewers: mzolotukhin

Subscribers: sanjoy, llvm-commits

Differential Revision: https://reviews.llvm.org/D35088

Modified:
    lldb/trunk/lit/lit.cfg

Modified: lldb/trunk/lit/lit.cfg
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/lit/lit.cfg?rev=307320&r1=307319&r2=307320&view=diff
==============================================================================
--- lldb/trunk/lit/lit.cfg (original)
+++ lldb/trunk/lit/lit.cfg Thu Jul  6 14:46:47 2017
@@ -95,8 +95,8 @@ if config.test_exec_root is None:
         lit_config.fatal('No site specific configuration available!')
 
     # Get the source and object roots.
-    llvm_src_root = lit.util.capture(['llvm-config', '--src-root']).strip()
-    llvm_obj_root = lit.util.capture(['llvm-config', '--obj-root']).strip()
+    llvm_src_root = subprocess.check_output(['llvm-config', '--src-root']).strip()
+    llvm_obj_root = subprocess.check_output(['llvm-config', '--obj-root']).strip()
     lldb_src_root = os.path.join(llvm_src_root, "tools", "lldb")
     lldb_obj_root = os.path.join(llvm_obj_root, "tools", "lldb")
 
@@ -132,7 +132,7 @@ if not os.path.exists(config.cxx):
 
 if platform.system() in ['Darwin']:
     try:
-        out = lit.util.capture(['xcrun', '--show-sdk-path']).strip()
+        out = subprocess.check_output(['xcrun', '--show-sdk-path']).strip()
         res = 0
     except OSError:
         res = -1




More information about the lldb-commits mailing list