[Lldb-commits] [PATCH] D34945: Adding Support for Error Strings in Remote Packets

[Ravitheja Addepally via Phabricator via lldb-commits]

ravitheja marked 4 inline comments as done.
ravitheja added inline comments.


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp:110
+  packet += ";";
+  packet += std::string(error.AsCString());
+  return SendPacketNoLock(packet);
----------------
labath wrote:
> Aren't you supposed to send these only if the client enabled the error response?
>From the discussions on the dev-list I thought the client needs to query if the server will send the error string or not and from the
server side its always enabled ?


================
Comment at: source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.h:64
 
+  PacketResult SendErrorResponse(Status &error);
+
----------------
labath wrote:
> Why the reference?
how about const reference ?


https://reviews.llvm.org/D34945