[Lldb-commits] [PATCH] D34553: Shorten sanitizer plugin names

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 23 08:13:39 PDT 2017

labath added a comment.

In https://reviews.llvm.org/D34553#789023, @kubamracek wrote:

> Oh wow, we really need to limit path lengths?

It's a bit annoying, but windows has issues with paths like that. It's actually possible to avoid it nowadays, if you use the right APIs, but not all programs have been updated to do that. Ironically enough, the error here comes from the MSVC linker, which means clang either succeeded in creating the object file, or failed silently doing that (I can't say which one as this was happening on the buildbot).

>   What about files like `./packages/Python/lldbsuite/test/functionalities/thread/concurrent_events/breakpoints_delayed_breakpoint_one_watchpoint/TestConcurrentBreakpointsDelayedBreakpointOneWatchpoint.py`?

That's another fine example of an incredibly long path, and it was causing some problems already (it broke dotest log file name length), but I've managed to work around those.

However, even without these limits, I feel that our file names/paths tend to be unnecessarily long.


More information about the lldb-commits mailing list