[Lldb-commits] [PATCH] D34553: Shorten sanitizer plugin names

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 23 05:48:52 PDT 2017


labath created this revision.
Herald added a subscriber: mgorny.

The new UndefinedBehaviorSanitizer plugin was breaking file path length
limits, because it's (fairly long name) appears multiple times in the
path. Cmake ends up putting the object file at path
tools/lldb/source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeFiles/lldbPluginInstrumentationRuntimeUndefinedBehaviorSanitizer.dir/UndefinedBehaviorSanitizerRuntime.cpp.obj
which is 191 characters long and very dangerously close to the 260
character path limit on windows systems (also, just the include line for
that file was breaking the 80 character line limit).

This renames the sanitizer plugins to use shorter names (asan, ubsan,
tsan). I think this will still be quite understandable to everyone as
those are the names everyone uses to refer to them anyway.


https://reviews.llvm.org/D34553

Files:
  source/API/SystemInitializerFull.cpp
  source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.cpp
  source/Plugins/InstrumentationRuntime/ASan/ASanRuntime.h
  source/Plugins/InstrumentationRuntime/ASan/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp
  source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.h
  source/Plugins/InstrumentationRuntime/AddressSanitizer/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/TSan/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.cpp
  source/Plugins/InstrumentationRuntime/TSan/TSanRuntime.h
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.cpp
  source/Plugins/InstrumentationRuntime/ThreadSanitizer/ThreadSanitizerRuntime.h
  source/Plugins/InstrumentationRuntime/UBSan/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.cpp
  source/Plugins/InstrumentationRuntime/UBSan/UBSanRuntime.h
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/CMakeLists.txt
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.cpp
  source/Plugins/InstrumentationRuntime/UndefinedBehaviorSanitizer/UndefinedBehaviorSanitizerRuntime.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D34553.103721.patch
Type: text/x-patch
Size: 13755 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170623/9c212ac4/attachment.bin>


More information about the lldb-commits mailing list