[Lldb-commits] [PATCH] D34400: Move Connection from Core to Host

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 20 06:28:12 PDT 2017

I had actually been considering going the other way. Moving connection and
all implementations to Utility. Host is a big contributor to the dependency
problems, so putting more stuff in seems like the wrong direction.

The end state i had in mind was similar to llvm support (which is more less
the equivalent of lldb host), where it has all the host specific
functionality but contains no deps.

With that in mind, thoughts on moving everything to Utility?
On Tue, Jun 20, 2017 at 5:56 AM Pavel Labath via Phabricator <
reviews at reviews.llvm.org> wrote:

> labath created this revision.
> Herald added a subscriber: mgorny.
> All implementations of the connection interface live in the Host module
> already, so it makes sense for the interface itself to be defined there.
> https://reviews.llvm.org/D34400
> Files:
>   include/lldb/Core/Connection.h
>   include/lldb/Host/Connection.h
>   include/lldb/Host/posix/ConnectionFileDescriptorPosix.h
>   include/lldb/Host/windows/ConnectionGenericFileWindows.h
>   source/Core/CMakeLists.txt
>   source/Core/Communication.cpp
>   source/Core/Connection.cpp
>   source/Host/CMakeLists.txt
>   source/Host/common/Connection.cpp
>   source/Host/posix/ConnectionFileDescriptorPosix.cpp
>   tools/lldb-server/Acceptor.h
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170620/9f0d46f4/attachment.html>

More information about the lldb-commits mailing list