[Lldb-commits] [PATCH] D33998: Add pretty-printer for wait(2) statuses and modernize the code handling them

Kamil Rytarowski via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 7 11:34:57 PDT 2017


krytarowski added inline comments.


================
Comment at: source/Host/common/Host.cpp:1001
+    return {Stop, uint8_t(WSTOPSIG(wstatus))};
+  llvm_unreachable("Unknown wait status");
+}
----------------
labath wrote:
> krytarowski wrote:
> > `WIFCONTINUED()`?
> I'm deliberately ignoring that, as we don't have a use for it yet. On linux you have to pass the a special flag to waitpid to receive those notifications, and we don't do that. Does it work the same way on netbsd? If it possible to get those during normal interaction (without WCONTINUED), then I need to add it (and probably netbsd code needs to handle it), but otherwise I propose to skip it for the time being.
I see, we need `WCONTINUED` too. We can skip it now.


https://reviews.llvm.org/D33998





More information about the lldb-commits mailing list