[Lldb-commits] [PATCH] D33778: Add a NativeProcessProtocol Factory class

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Jun 1 11:04:56 PDT 2017

zturner added inline comments.

Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:148
-  ::pid_t Attach(lldb::pid_t pid, Status &error);
+  static llvm::Expected<std::vector<::pid_t>> Attach(::pid_t pid);
Before it was only returning 1, now it's returning a vector.  Any reason?

Comment at: source/Plugins/Process/Linux/NativeProcessLinux.h:152
-  static void *MonitorThread(void *baton);
+  void InitializeThreads(llvm::ArrayRef<::pid_t> tids);
Shouldn't this be `tid_t`?


More information about the lldb-commits mailing list