[Lldb-commits] [PATCH] D32930: New framework for lldb client-server communication tests.
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 31 04:21:14 PDT 2017
labath added a comment.
Thanks for the support, @beanz.
Comment at: unittests/tools/CMakeLists.txt:1
+if(UNIX AND NOT APPLE)
> labath wrote:
> > This is not what I meant. The only targets (at least until we have debugserver support) that can realistically pass these tests are linux, android, and netbsd. The other targets (right now, I guess that would mean freebsd) don't even pretend to support debugging via lldb-server, so we should not fail their build because of that. Check for usages of CMAKE_SYSTEM_NAME to see how to discriminate those.
> Darwin pretends to support lldb-server in several places, it would be nice to be able to run these tests on Darwin if they work. One of my big goals for the future of testing on LLDB is to get to the point where the only differences in test coverage when running tests on different hosts is truly platform-specific code. Today we are nowhere near that.
> Also, as Pavel pointed out in email, the lldb-server tests are also run against debugserver, so we need to make sure that still works too.
Which lldb-server support do you refer to here?
There is some llgs (debugging) support in lldb-server, but I have no idea what's the state of it -- it was added by Todd during his week of code as an "NFC" commit, and it hasn't been touched since. I'd like to avoid this keeping the build red if there is no intention of working on it.
The "platform" mode of lldb-server should work on darwin afaik, and we definitely want to be able to run it there. It's not what we are focusing on now though. We'd like to migrate the "debug" tests first (there are no "platform" tests), so the old ones can be removed.
In any case, I think of the apple exclusion part as a temporary thing, so we can check this in without breaking the build, we will pretty soon want to include it as well, so that we can run debugserver tests, at least. (At which point we will need a different way of disabling unsupported tests).
More information about the lldb-commits