[Lldb-commits] [PATCH] D33434: Added new API to SBStructuredData class

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 24 10:13:08 PDT 2017


labath added inline comments.


================
Comment at: packages/Python/lldbsuite/test/python_api/sbstructureddata/TestStructuredDataAPI.py:43
+        # Now launch the process, and do not stop at entry point.
+        process = target.LaunchSimple(
+            None, None, self.get_process_working_directory())
----------------
Why do you need a process for this test? It sounds like all you're doing is playing around with SBStructuredData. You can remove everything from here including the `self.build()` call and the inferior source.

Then you can annotate this test with NO_DEBUG_INFO_TESTCASE = True, as it definitely does not depend on debug info.


https://reviews.llvm.org/D33434





More information about the lldb-commits mailing list