[Lldb-commits] [PATCH] D32585: Implementation of remote packets for Trace data.

[Ravitheja Addepally via Phabricator via lldb-commits]

ravitheja added inline comments.


================
Comment at: include/lldb/Host/common/NativeProcessProtocol.h:352
+                          lldb::tid_t thread = LLDB_INVALID_THREAD_ID) {
+    return Status("Not implemented");
+  }
----------------
krytarowski wrote:
> This is Linuxism. Not every OS can trace on per-thread basis.
Yes , the trace id (uid in the example u commented) could refer to a trace instance on a process or a thread. So the following two things can happen ->

1) uid corresponds to a trace instance on a process. In this case thread only needs to specified if the user wants to stop tracing on an individual thread inside a process. If thread level tracing is not supported then thread arg need not be specified.

2) uid corresponds to a trace instance on a thread. In which case the thread argument need not specified and the trace instance should be able to stop the trace.

So to summarize the thread argument only comes into picture when thread level tracing is supported and the user wants to stop tracing on an individual thread of a process being traced.


https://reviews.llvm.org/D32585