[Lldb-commits] [PATCH] D33241: Add Status -- llvm::Error glue

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 16 17:13:08 PDT 2017


jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.

This seems fine to me.

Zachary didn't give reasons why he didn't like the conversion form so I can't really assess that point.  The use in the ErrorConversion test case seems pretty natural to me, but it's possible I'm missing whatever was bugging him about this.  So I'll okay this for my part, but if you guys want to continue discussing, have at it!


https://reviews.llvm.org/D33241





More information about the lldb-commits mailing list