[Lldb-commits] [PATCH] D33035: Tool for using Intel(R) Processor Trace hardware feature
Kamil Rytarowski via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 10 11:38:21 PDT 2017
krytarowski added a comment.
In https://reviews.llvm.org/D33035#751280, @clayborg wrote:
> In https://reviews.llvm.org/D33035#751264, @krytarowski wrote:
> > Can we please use the generic process plugin code, not the specific Linux one? If the generic code is insufficient - we should adjust it and alter instances of it (Linux and BSD).
> There should be no need to ever #include something from a plug-in in code the gets loaded externally. We should rely on the error strings themselves, not be comparing them to some value. SBError has an error type (generic, posix, mach-kernel, expression results, windows). It we are going to do anything we can make up a new set of them, but the code in this patch is relying on the values, when it should just be using the string value. If the string value wasn't set correctly, fix that is the code that creates the errors.
Thank you for explanation. This is even better and ideal.
More information about the lldb-commits