[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

[vignesh balu via lldb-commits]

you mean like this "exe = os.path.join('./newdir/','proc_attach')". I can't
use "os.getcwd" as it will become the absolute path which we should not use.

thanks,
vbalu

On Wed, May 3, 2017 at 11:51 AM, Zachary Turner <zturner at google.com> wrote:

> Can you rewrite the exe path computation to use os.path.join so we're not
> assuming posix syntax?
> On Tue, May 2, 2017 at 11:11 PM vignesh balu via Phabricator via
> lldb-commits <lldb-commits at lists.llvm.org> wrote:
>
>> vbalu updated this revision to Diff 97550.
>> vbalu added a comment.
>>
>> Corrected the code. Now this test will fail without
>> https://reviews.llvm.org/D32271 patch.
>>
>>
>> https://reviews.llvm.org/D32522
>>
>> Files:
>>   packages/Python/lldbsuite/test/functionalities/process_
>> attach/TestProcessAttach.py
>>
>>
>> Index: packages/Python/lldbsuite/test/functionalities/process_
>> attach/TestProcessAttach.py
>> ===================================================================
>> --- packages/Python/lldbsuite/test/functionalities/process_
>> attach/TestProcessAttach.py
>> +++ packages/Python/lldbsuite/test/functionalities/process_
>> attach/TestProcessAttach.py
>> @@ -8,6 +8,7 @@
>>  import os
>>  import time
>>  import lldb
>> +import shutil
>>  from lldbsuite.test.decorators import *
>>  from lldbsuite.test.lldbtest import *
>>  from lldbsuite.test import lldbutil
>> @@ -38,6 +39,25 @@
>>          process = target.GetProcess()
>>          self.assertTrue(process, PROCESS_IS_VALID)
>>
>> +    def test_attach_to_process_frm_different_dir_by_id(self):
>> +        """Test attach by process id"""
>> +        os.mkdir(os.path.join(os.getcwd(),'newdir'))
>> +        self.buildProgram('main.cpp','newdir/proc_attach')
>> +        exe = './newdir/proc_attach'
>> +        self.addTearDownHook(lambda: shutil.rmtree(os.path.join(os.
>> getcwd())))
>> +
>> +        # Spawn a new process
>> +        popen = self.spawnSubprocess(exe)
>> +        self.addTearDownHook(self.cleanupSubprocesses)
>> +
>> +        os.chdir('newdir')
>> +        self.runCmd("process attach -p " + str(popen.pid))
>> +
>> +        target = self.dbg.GetSelectedTarget()
>> +
>> +        process = target.GetProcess()
>> +        self.assertTrue(process, PROCESS_IS_VALID)
>> +
>>      def test_attach_to_process_by_name(self):
>>          """Test attach by process name"""
>>          self.build()
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170503/f880736b/attachment.html>