[Lldb-commits] [PATCH] D32866: Fix -DLLVM_BUILD_TESTS=ON lldb build

[Jonathan Roelofs via Phabricator via lldb-commits]

jroelofs created this revision.
Herald added a subscriber: mgorny.

There are two issues here. The first:

  liblldbHost.a(Editline.cpp.o):(.debug_addr+0x238): undefined reference to `el_get'

when linking InterpreterTests, is caused by -ledit coming after liblldbHost.a in the link line.

The second:

  liblldbCore.a(IOHandler.cpp.o):(.debug_addr+0x2564): undefined reference to `del_panel'

because libpanel.a and liblldbCore.a are out of order in the link line.


https://reviews.llvm.org/D32866

Files:
  source/Core/CMakeLists.txt
  source/Host/CMakeLists.txt


Index: source/Host/CMakeLists.txt
===================================================================
--- source/Host/CMakeLists.txt
+++ source/Host/CMakeLists.txt
@@ -48,6 +48,7 @@
   add_host_subdirectory(common
     common/Editline.cpp
     )
+  list(APPEND EXTRA_LIBS edit)
 endif()
 
 add_host_subdirectory(posix
@@ -160,7 +161,7 @@
 endif()
 
 if (CMAKE_SYSTEM_NAME MATCHES "NetBSD")
- set(EXTRA_LIBS kvm)
+ list(APPEND EXTRA_LIBS kvm)
 endif ()
 
 add_lldb_library(lldbHost
Index: source/Core/CMakeLists.txt
===================================================================
--- source/Core/CMakeLists.txt
+++ source/Core/CMakeLists.txt
@@ -69,6 +69,7 @@
   LINK_COMPONENTS
     Support
     Demangle
+    ${LLDB_SYSTEM_LIBS}
   )
 
 # Needed to properly resolve references in a debug build.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32866.97828.patch
Type: text/x-patch
Size: 800 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170504/8ec256c9/attachment-0001.bin>