[Lldb-commits] [PATCH] D32823: Remove an expensive lock from Timer

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

Don't forget to update the usages in unit tests (and make sure the check-lldb-unit target passes).

Seems reasonable, however: I am not sure who actually uses these timers. I'd be tempted to just remove the timers that are causing the contention.



================
Comment at: include/lldb/Core/Timer.h:26
 
+class TimerCategory {
+public:
----------------
I would put this inside the Timer class, so that we can refer to it as Timer::Category. I guess tastes might differ.


================
Comment at: source/Core/Timer.cpp:147
 
-  const size_t count = sorted_iterators.size();
+  const size_t count = sorted.size();
   for (size_t i = 0; i < count; ++i) {
----------------
This could be a range-based loop.


================
Comment at: source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5421
         char *buf = (char *) malloc (ident_command.cmdsize);
-        if (buf != nullptr 
+        if (buf != nullptr
             && m_data.CopyData (offset, ident_command.cmdsize, buf) == ident_command.cmdsize) {
----------------
I am not sure how you format your changes, but you should make sure you format only the lines you've touched, and not the whole files. git-clang-format <https://github.com/llvm-mirror/clang/blob/master/tools/clang-format/git-clang-format> will do that for you -- when you set it up, you just run `git clang-format HEAD^` and it will format your last patch).


Repository:
  rL LLVM

https://reviews.llvm.org/D32823