[Lldb-commits] [PATCH] Fix Ubuntu build break with gcc 5.4

[Pavel Labath via lldb-commits]

It seems xiangzhai has already "cranked up a review" :) (D32787), so
moving the discussion there.

On 3 May 2017 at 09:57, Pavel Labath <labath at google.com> wrote:
> This doesn't make things any worse, but a better solution would be to
> figure out why cmake has not detected ppoll(2) support, as lldb on
> linux is useless without the signal polling stuff. If your system does
> have ppoll, but we're not detecting it, we will have to fix detection
> code. On the off chance that you don't have one (it was introduced
> ages ago, so I would be surprised by that, but I guess it's still
> possible), then we can fall back to using pselect(2).
>
>
>
> On 3 May 2017 at 00:13, Robinson, Paul via lldb-commits
> <lldb-commits at lists.llvm.org> wrote:
>> Recently I started seeing a build error from a tree that has lldb in it;
>> I don't know whether the problem is my configuration, or Ubuntu, or gcc,
>> or what, but gcc complains that it can't convert 'int' to 'sigset_t' on
>> the return statement.
>>
>> This naïve one-liner fixes it, although I don't know anything about
>> signal stuff.  Didn't seem worth cranking up a Phab review for this...
>> --paulr
>>
>> Index: source/Host/common/MainLoop.cpp
>> ===================================================================
>> --- source/Host/common/MainLoop.cpp     (revision 301939)
>> +++ source/Host/common/MainLoop.cpp     (working copy)
>> @@ -155,7 +155,7 @@
>>
>>  sigset_t MainLoop::RunImpl::get_sigmask() {
>>  #if SIGNAL_POLLING_UNSUPPORTED
>> -  return 0;
>> +  return sigset_t();
>>  #else
>>    sigset_t sigmask;
>>    int ret = pthread_sigmask(SIG_SETMASK, nullptr, &sigmask);
>>
>>
>> _______________________________________________
>> lldb-commits mailing list
>> lldb-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits