[Lldb-commits] [PATCH] D32598: Prime module caches outside of the module list lock for better parallelism

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

This is picky but can you call it "symbol-cache-priming".  The help text explains it, but this is a very specific cache so we should scope it in case we have some other one later on.

And we really need to test that both modes continue to work.  If we're always fetching symbols up-front by default, then it will be easy for triggering lazy loading to break.  One way to do that would to add another mode of the testsuite (like the dwarf vrs. dSYM vrs. dso vrs. gmodules.)  But at some point continually multiplying runs of the whole testsuite is going to make it so time consuming people will stop running all the options.

In this case, it's probably sufficient to add a test that runs to a shared-library scoped breakpoint, and performs some operations that require symbols from other shared-libraries and makes sure they succeed.  Then do that with the setting on and off.


Repository:
  rL LLVM

https://reviews.llvm.org/D32598