[Lldb-commits] [PATCH] D32434: ObjectFileELF: Fix symbol lookup in bss section

[Pavel Labath via Phabricator via lldb-commits]

labath requested review of this revision.
labath added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D32434#737205, @labath wrote:

> In https://reviews.llvm.org/D32434#737179, @zturner wrote:
>
> > If you look at the source code of yaml2obj, all this boils down to a single call to `ELFState<T>::writeELF`.  If you just link against that, we could avoid even shelling out to an external tool, and the YAML could be a string literal defined inside the unit test cpp file.  This would also greatly simplify the xcode build.
> >
> > Thoughts?
>
>
> I like that. Let me see how that goes..


Unfortunately, it's not going to be that easy. All of the yaml->elf conversion code lives in tools/yaml2obj, and is not a part of any library any library that we could pull in. Maybe there's a case to be made for making yaml2obj a library, but I am not sure if this is the time to do that.


https://reviews.llvm.org/D32434