[Lldb-commits] [PATCH] D32421: Fix segfault resulting from empty print prompt

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 25 10:32:49 PDT 2017


xiaobai added a comment.

@krytarowski: Thanks for checking! I can set up a NetBSD environment sometime in the next few days to see what's going on. While it might not be an issue on this platform, I think it's an issue that MoveCursor() accesses `m_input_lines[m_input_lines.size() - 1]` without verifying that `m_input_lines.size() > 0` explicitly.

@labath: After reading over what you said, I believe I understand what you're saying. An older version of lldb (I have checked with the default version provided on MacOS Sierra 10.12.3) will leave the dangling "1: ", but I agree that consistency will be better than going back to the old behavior. I'll change my patch and add a test in the next day or two. Thank you so much for your feedback! :)


https://reviews.llvm.org/D32421





More information about the lldb-commits mailing list