[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

Ed Maste via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Apr 21 18:41:00 PDT 2017

emaste added a comment.

In https://reviews.llvm.org/D32125#728166, @krytarowski wrote:

> Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ years ago.
> It's perhaps no-op, but it might be noted in the commit message what platforms are supposed to be improved.

I'd say it's better to put a comment in the source where it's set.


More information about the lldb-commits mailing list