[Lldb-commits] [PATCH] D29581: Initial implementation of SB APIs for Tracing support.
Ravitheja Addepally via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Apr 20 04:24:53 PDT 2017
ravitheja marked 7 inline comments as done.
ravitheja added inline comments.
Comment at: include/lldb/API/SBProcess.h:251
+ /// supported. To obtain the actual used trace options please
+ /// use the GetTraceConfig API. For the custom parameters, only
+ /// the parameters recognized by the target would be used and
> Is GetTraceConfig an internal API? If so, lets not mention it here. You general comments should suffice.
No, its not an internal API, so just to throw some light to it, Processor trace integration for Linux does not support all buffer sizes so we are rounding the buffer sizes to the nearest supported buffer size and through GetTraceConfig we plan to communicate the actual trace buffer size being.
More information about the lldb-commits