[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5
Jason Molenda via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Apr 18 20:14:48 PDT 2017
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Looks fine to me, I don't know the debug_types sections that you're supporting but I read over the code and don't have any problems.
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDIE.h:92
+ // .debug_info or the .debug_types section so anyone extracting data from
+ // a DIE must use the correct data.
DWARFDIE::GetData() handles the difference between debug_info / debug_types so the callers of this method don't need to worry about that, correct? Maybe the comment could say
// Get the data that contains the attribute values for this DIE. Support
// for .debug_types means that any DIE can have its data either in the
// .debug_info or the .debug_types section; this method will return the
// correct section data.
More information about the lldb-commits