[Lldb-commits] [PATCH] D31824: Update DebugServer to support IPv6 over TCP
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 12 14:36:29 PDT 2017
clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.
Looks fine as long as all of the old modes work. :
- "*:1234" that will accept a connection from any host on port 1234
- "foo.bar.com:1234" only accept connections from "foo.bar.com" on port 1234
- "localhost:1234" where make sure not to lookup "localhost" since people have been known to edit some config file and this no longer works, we currently just substitute "127.0.0.1" IPv4, and now we should or "::1" for IPv6
- can't remember what used to happen when you only specify a port number, but that shouldn't change either
Can you ensure you tests catch these things? Any change here can affect many users, so we should be careful here to not regress.
More information about the lldb-commits