[Lldb-commits] [PATCH] D31822: [NFC] Adding a new wrapper for getaddrinfo

Chris Bieneman via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Apr 12 14:07:04 PDT 2017

beanz added inline comments.

Comment at: include/lldb/Host/SocketAddress.h:44-45
+  //----------------------------------------------------------------------------
+  static std::vector<SocketAddress> GetAddressInfo(const char *hostname,
+                                                 const char *servname);
zturner wrote:
> What about using `Twine` here instead of `const char *` literals?
I don't want to use `Twine` for this because in other patches I'm pulling this into debugserver which doesn't have any dependency on LLVM.


More information about the lldb-commits mailing list