[Lldb-commits] [PATCH] D31825: Fix loading core(5) files from NetBSD 7.99.67

Kamil Rytarowski via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 11 11:35:21 PDT 2017


This patch happened to does not fully work for me (NetBSD-CORE@ switches
were skipped), I will be back to it once I will get my current efforts
done on watchpoints and fpr.

Thank you for the initial scratch!

On 11.04.2017 17:14, Zachary Turner wrote:
> Just to be clear, this patch was only intended to be a starting point. I
> didn't run the test suite or do anything other than verify that the core
> loaded. ArchSpec is a pretty core class so touching it in this manner is
> likely to have many side effects that you'll need to work out.
> Most likely so many tests fail on NetBSD that it masks the regressions,
> but you should at least be able to diff your test results before/after
> On Tue, Apr 11, 2017 at 6:12 AM Kamil Rytarowski via Phabricator
> <reviews at reviews.llvm.org <mailto:reviews at reviews.llvm.org>> wrote:
>     krytarowski added a comment.
>     I might need some guidance to address the asserts appropriately in
>     finite time.
>     In general we set osabi to generic unix (value 0), and NetBSD
>     core(5) files are distinguished only (or mostly) with "NetBSD-CORE*"
>     notes.
>     Repository:
>       rL LLVM
>     https://reviews.llvm.org/D31825

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170411/429874c9/attachment.sig>

More information about the lldb-commits mailing list