[Lldb-commits] [PATCH] D31451: New C++ function name parsing logic

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Apr 6 16:06:54 PDT 2017


jingham added a comment.

I'm sorry, I don't have time actually review the code here for correctness...  But can you make sure that this also rejects a two or three field selector, not just "selector:" but "selector:otherField:"?  That seems sufficiently different that you might get the one : but not the two : form right.  You could test 3 & more colons, but at that point it's probably overkill.


Repository:
  rL LLVM

https://reviews.llvm.org/D31451





More information about the lldb-commits mailing list