[Lldb-commits] [PATCH] D31357: Support Unit Testing debugserver

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

On the small points side: for lldb code we use lower-case, _ separated names for local variables, the point being that it allow you to tell at a glance what's a local and what's an ivar.  Looks like you use a mixture of the two styles?  exit_status, result, etc. alongside WriteSize, etc...  It doesn't matter as much for a test case, but still it's good to be consistent.

More substantial, what happens to a gtest case if the test case program aborts?  Remembering that the way the world works, this failure is bound to happen only intermittently on some server you can't access, so it's good to collect as much info as you can on failure.  If the tests report a good stack trace on abort, that's probably fine, but otherwise it would be good to figure out a way to back out and leave some trace.


https://reviews.llvm.org/D31357