[Lldb-commits] [PATCH] D31450: Battery of NetBSD support improvements

[Kamil Rytarowski via Phabricator via lldb-commits]

krytarowski added inline comments.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383
   // On Linux the executable is indicated by an empty path in the entry. On
   // FreeBSD and on Android it is the full path to the executable.
 
----------------
kettenis wrote:
> Probably should update this comment
Right!


================
Comment at: source/Plugins/Process/elf-core/ProcessElfCore.cpp:456
+}
+
 // Parse a FreeBSD NT_PRSTATUS note - see FreeBSD sys/procfs.h for details.
----------------
kettenis wrote:
> Unfortunate that the note numbers are different from architecture to architecture on NetBSD.
Yes, we reuse `PT_GETREGS` and `PT_GETFPREGS` per port variables.

This is placeholder to start working on amd64 with threading support.


Repository:
  rL LLVM

https://reviews.llvm.org/D31450