[Lldb-commits] [PATCH] D31371: Stop calling ValueObject::SetName from synthetic child providers

[Tamas Berghammer via Phabricator via lldb-commits]

tberghammer added a comment.

SBValue::SetName is not part of the SB API (what is the right decision IMO as an SBValue should be mostly immutable) so this issue doesn't effect it. I looked through the code in examples/synthetic/gnu_libstdcpp.py and it is always using one of the SBValue::Create* method to produce new SBValue what will create a new value object one way or the other. Considering that nobody complained about the missing SetName method at the SB API level I don't see a big need for exposing the Clone method there. At the same line if SetName/Clone isn't part of the SB API then I think we shouldn't document it at the webpage.

(I will upload a fix for the spelling errors later)


https://reviews.llvm.org/D31371