[Lldb-commits] [PATCH] D31031: Move GetAuxvData from Host to relevant process plugins

[Pavel Labath via Phabricator via lldb-commits]

labath created this revision.
Herald added subscribers: mgorny, srhines.

GetAuxvData was causing dependencies from host to target and linux
process modules. It also does not fit netbsd use case, as there we can
only read the auxiliary vector with ptrace, which is better done in the
process plugin, with the other ptrace calls.

I resolve these issues by moving the freebsd and linux versions into the
relevant process plugins. In case of linux, this required adding an
interface in NativeProcessProtocol. The empty definitions on other
platforms can simply be removed.

To get the code compiling I had to add ProcessGdbRemote -> ProcessLinux
dependency, which was not caught before because we depended on it
transitively.


https://reviews.llvm.org/D31031

Files:
  include/lldb/Host/Host.h
  include/lldb/Host/common/NativeProcessProtocol.h
  source/Host/CMakeLists.txt
  source/Host/freebsd/Host.cpp
  source/Host/linux/Host.cpp
  source/Host/macosx/Host.mm
  source/Host/netbsd/Host.cpp
  source/Host/windows/Host.cpp
  source/Plugins/Process/FreeBSD/ProcessFreeBSD.cpp
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/gdb-remote/CMakeLists.txt
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31031.92000.patch
Type: text/x-patch
Size: 12675 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170316/153ce6a7/attachment-0001.bin>