[Lldb-commits] [PATCH] D30817: BreakpointResolverFileLine: Correct treatment of move-to-nearest-code for multiple modules

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 14 03:22:27 PDT 2017


labath updated this revision to Diff 91693.
labath added a comment.
Herald added a subscriber: ki.stfu.

I've updated the code as suggested. For the "fudge factor" I chose one, so that
this at least works in the fairly common case where you put an empty line
between two tiny functions. The "breakpoint on return type" case should still
work as long as the retyrn type does not span multiple lines, which I think is a
good compromise.

This required some tweaks to existing tests, as two of them were actually
relying on the move-the-breakpoint-into-a-function behavior. I have removed the
corresponding check from TestBreakpointOptions, as the new test supersedes that,
and I have tweaked TestMiBreak to test the move-nearest functionality
differently.

Let me know what you think.


https://reviews.llvm.org/D30817

Files:
  include/lldb/Breakpoint/BreakpointResolverFileLine.h
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_options/TestBreakpointOptions.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_options/main.cpp
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/Makefile
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/TestMoveNearest.py
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/foo.cpp
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/foo.h
  packages/Python/lldbsuite/test/functionalities/breakpoint/move_nearest/main.cpp
  packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/TestMiBreak.py
  packages/Python/lldbsuite/test/tools/lldb-mi/breakpoint/main.cpp
  source/Breakpoint/BreakpointResolverFileLine.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D30817.91693.patch
Type: text/x-patch
Size: 16843 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170314/00b075a0/attachment-0001.bin>


More information about the lldb-commits mailing list