[Lldb-commits] [PATCH] D30926: Fix MSVC signed/unsigned conversion and size_t conversion warnings in LLDB

Zachary Turner via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 13 21:29:50 PDT 2017


Lgtm, no need to request a review for these kind of trivial warning fixes
On Mon, Mar 13, 2017 at 9:11 PM Hugh Bellamy via Phabricator via
lldb-commits <lldb-commits at lists.llvm.org> wrote:

> hughbe updated this revision to Diff 91670.
> hughbe added a comment.
>
> Fix file names
>
>
> https://reviews.llvm.org/D30926
>
> Files:
>   source/Core/FormatEntity.cpp
>
>
> Index: source/Core/FormatEntity.cpp
> ===================================================================
> --- source/Core/FormatEntity.cpp
> +++ source/Core/FormatEntity.cpp
> @@ -64,14 +64,14 @@
>  #define ENTRY_CHILDREN(n, t, f, c)
>      \
>    {
>       \
>      n, nullptr, FormatEntity::Entry::Type::t,
>       \
> -        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c),
> c,     \
> -        false
>       \
> +        FormatEntity::Entry::FormatType::f, 0,
>      \
> +        static_cast<uint32_t>(llvm::array_lengthof(c)), c, false
>      \
>    }
>  #define ENTRY_CHILDREN_KEEP_SEP(n, t, f, c)
>       \
>    {
>       \
>      n, nullptr, FormatEntity::Entry::Type::t,
>       \
> -        FormatEntity::Entry::FormatType::f, 0, llvm::array_lengthof(c),
> c,     \
> -        true
>      \
> +        FormatEntity::Entry::FormatType::f, 0,
>      \
> +        static_cast<uint32_t>(llvm::array_lengthof(c)), c, true
>       \
>    }
>  #define ENTRY_STRING(n, s)
>      \
>    {
>       \
>
>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20170314/bdb6c1c9/attachment.html>


More information about the lldb-commits mailing list