[Lldb-commits] [PATCH] D30006: [lldb] Remove the "MemoryHistory" plugin type and merge it into InstrumentationRuntime [NFC]

[Jim Ingham via Phabricator via lldb-commits]

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

The InstrumentationRuntime implements a fairly specific model of something that might provide history threads.  There has to be a module in the program that implements this, and a breakpoint that presumably triggers the report.  What if you implemented this instead with dtrace behind the program's back?  It wouldn't look like an InstrumentationRuntime plugin as currently sketched out.

This doesn't necessarily mean that the MemoryHistory has to stand separate from the InstrumentationRuntime.  Maybe there should be a more general base for InstrumentationRuntime that has the notion of providing memory histories but is less specific about how it goes about doing so?


https://reviews.llvm.org/D30006