[Lldb-commits] [PATCH] D30789: Make file and directory name completion work properly on Windows.

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 9 16:35:23 PST 2017

amccarth added inline comments.

Comment at: lldb/source/Commands/CommandCompletions.cpp:108
+                                  StringList &matches,
+                                  TildeExpressionResolver *Resolver) {
+  // Use the default resolver if one isn't explicitly specified.
I know you're not inventing this API, but since you're changing it, can you do something about the `bool` and `bool &` parameters?  It makes reading the call sites difficult without referring back here to see what those mean.

Comment at: lldb/source/Commands/CommandCompletions.cpp:112
+  if (!Resolver)
+    Resolver = &SR;
This leaves the caller with no way to say the don't want a tilde resolver.  I didn't expect that from reading the API.  Perhaps a comment on the API could clarify that you're going to get this default behavior if you specify nullptr.


More information about the lldb-commits mailing list