[Lldb-commits] [PATCH] D30698: Resubmit "Use LLVM for all stat related calls"

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 7 09:28:50 PST 2017

labath added a comment.

Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:197
+  namespace fs = llvm::sys::fs;
+  if (fs::get_file_type(local_path_spec.GetPath(), false) !=
+      fs::file_type::symlink_file)
labath wrote:
> This still breaks TestCompDirSymLink.py. I haven't yet dug into why, but it looks like some problem in the get_file_type implementation.
ok, so the problem is in `llvm::sys::fs::fillStatus` implementation. It is missing the call to `S_ISLNK` to decode the symlink bit (probably because it was not necessary until now).


More information about the lldb-commits mailing list