[Lldb-commits] [PATCH] D30457: [LLDB][MIPS] Core Dump Support

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 7 07:05:37 PST 2017

labath added a comment.

Thank you for updating that. Let me know what the make_core investigation uncovers.

Comment at: source/Plugins/Process/Linux/NativeRegisterContextLinux_mips64.cpp:164
+  case llvm::Triple::mips64el:
+    const RegisterContextLinux_mips64 *reg_context_mips64;
+    reg_context_mips64 = (const RegisterContextLinux_mips64 *)
no need to fiddle with pointers:
`const auto &context = static_cast<const RegisterContextLinux_mips64 &>(GetRegisterInfoInterface());`

Comment at: source/Plugins/Process/elf-core/ThreadElfCore.h:22
Thank you for introducing these constants. Since we already started using constexpr variables for constants, let's make these such as well. You could even hide these into the cpp file if you move the GetSize function there (it's grown so big it does not belong to a header anyway).


More information about the lldb-commits mailing list